Skip to content

fix: move non_differentiable to special module for JET masking #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

fix: move non_differentiable to special module for JET masking #131

merged 1 commit into from
Jun 14, 2025

Conversation

@MilesCranmer
Copy link
Member

@MilesCranmer MilesCranmer commented Jun 14, 2025

No description provided.

@MilesCranmer MilesCranmer force-pushed the fix-zygote-mutation branch from ac564d3 to 0e66242 Compare June 14, 2025 20:22
@MilesCranmer MilesCranmer enabled auto-merge June 14, 2025 20:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2025 •
edited
Loading

Benchmark Results (Julia v1)

Time benchmarks
master 0e66242... master / 0e66242...
eval/ComplexF32/evaluation 7.26 ± 0.56 ms 7.21 ± 0.56 ms 1.01 ± 0.11
eval/ComplexF64/evaluation 10.7 ± 0.84 ms 10.8 ± 0.87 ms 0.989 ± 0.11
eval/Float32/derivative 11.6 ± 0.49 ms 11.8 ± 0.66 ms 0.982 ± 0.069
eval/Float32/derivative_turbo 11.5 ± 0.59 ms 11.6 ± 0.57 ms 0.994 ± 0.07
eval/Float32/evaluation 2.72 ± 0.29 ms 2.75 ± 0.27 ms 0.991 ± 0.14
eval/Float32/evaluation_bumper 0.564 ± 0.016 ms 0.597 ± 0.016 ms 0.946 ± 0.036
eval/Float32/evaluation_turbo 0.509 ± 0.028 ms 0.509 ± 0.03 ms 0.998 ± 0.081
eval/Float32/evaluation_turbo_bumper 0.561 ± 0.015 ms 0.598 ± 0.016 ms 0.938 ± 0.035
eval/Float64/derivative 14.7 ± 1.2 ms 15.1 ± 1.2 ms 0.975 ± 0.11
eval/Float64/derivative_turbo 15.1 ± 1.1 ms 15.2 ± 1.2 ms 0.995 ± 0.11
eval/Float64/evaluation 3.11 ± 0.33 ms 3.15 ± 0.35 ms 0.989 ± 0.15
eval/Float64/evaluation_bumper 1.18 ± 0.043 ms 1.25 ± 0.042 ms 0.946 ± 0.047
eval/Float64/evaluation_turbo 0.998 ± 0.065 ms 1.01 ± 0.066 ms 0.991 ± 0.091
eval/Float64/evaluation_turbo_bumper 1.18 ± 0.043 ms 1.25 ± 0.044 ms 0.945 ± 0.048
utils/combine_operators/break_sharing 0.039 ± 0.00056 ms 0.0404 ± 0.00096 ms 0.965 ± 0.027
utils/convert/break_sharing 26.1 ± 1.8 μs 26.8 ± 1.2 μs 0.972 ± 0.08
utils/convert/preserve_sharing 0.0966 ± 0.0048 ms 0.101 ± 0.0059 ms 0.958 ± 0.074
utils/copy/break_sharing 26.7 ± 1.3 μs 27.2 ± 1.3 μs 0.98 ± 0.068
utils/copy/preserve_sharing 0.0976 ± 0.0054 ms 0.0991 ± 0.0052 ms 0.985 ± 0.075
utils/count_constant_nodes/break_sharing 12.6 ± 1 μs 12.7 ± 0.44 μs 0.99 ± 0.089
utils/count_constant_nodes/preserve_sharing 0.0851 ± 0.0039 ms 0.0865 ± 0.0049 ms 0.984 ± 0.071
utils/count_depth/break_sharing 13.1 ± 0.95 μs 13 ± 0.44 μs 1.01 ± 0.081
utils/count_nodes/break_sharing 11.6 ± 0.4 μs 11.5 ± 0.39 μs 1 ± 0.049
utils/count_nodes/preserve_sharing 0.0849 ± 0.0042 ms 0.0853 ± 0.0046 ms 0.995 ± 0.073
utils/get_set_constants!/break_sharing 0.0336 ± 0.0017 ms 0.0335 ± 0.0015 ms 1 ± 0.068
utils/get_set_constants!/preserve_sharing 0.176 ± 0.0088 ms 0.179 ± 0.0095 ms 0.986 ± 0.072
utils/get_set_constants_parametric 0.0442 ± 0.0029 ms 0.0446 ± 0.0024 ms 0.99 ± 0.084
utils/has_constants/break_sharing 6.71 ± 0.5 μs 6.45 ± 0.48 μs 1.04 ± 0.11
utils/has_operators/break_sharing 2.52 ± 0.16 μs 2.46 ± 0.18 μs 1.02 ± 0.099
utils/hash/break_sharing 23.1 ± 0.66 μs 22.6 ± 0.59 μs 1.02 ± 0.04
utils/hash/preserve_sharing 0.0965 ± 0.0044 ms 0.0984 ± 0.0056 ms 0.98 ± 0.071
utils/index_constant_nodes/break_sharing 24.5 ± 1 μs 24.3 ± 0.76 μs 1.01 ± 0.052
utils/index_constant_nodes/preserve_sharing 0.0972 ± 0.0049 ms 0.097 ± 0.0043 ms 1 ± 0.067
utils/is_constant/break_sharing 7.19 ± 0.51 μs 7.17 ± 0.51 μs 1 ± 0.1
utils/simplify_tree/break_sharing 0.158 ± 0.0027 ms 0.16 ± 0.0026 ms 0.987 ± 0.023
utils/simplify_tree/preserve_sharing 0.208 ± 0.0085 ms 0.212 ± 0.0087 ms 0.978 ± 0.057
utils/string_tree/break_sharing 0.47 ± 0.022 ms 0.467 ± 0.02 ms 1.01 ± 0.064
utils/string_tree/preserve_sharing 0.577 ± 0.022 ms 0.589 ± 0.024 ms 0.978 ± 0.055
time_to_load 0.213 ± 0.0022 s 0.216 ± 0.0035 s 0.984 ± 0.019
Memory benchmarks
master 0e66242... master / 0e66242...
eval/ComplexF32/evaluation 0.99 k allocs: 2.53 MB 0.981 k allocs: 2.51 MB 1.01
eval/ComplexF64/evaluation 1 k allocs: 5.11 MB 0.996 k allocs: 5.07 MB 1.01
eval/Float32/derivative 4.66 k allocs: 17.6 MB 4.63 k allocs: 17.4 MB 1.01
eval/Float32/derivative_turbo 4.68 k allocs: 17.6 MB 4.69 k allocs: 17.7 MB 0.997
eval/Float32/evaluation 0.99 k allocs: 1.29 MB 0.975 k allocs: 1.27 MB 1.02
eval/Float32/evaluation_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float32/evaluation_turbo 0.966 k allocs: 1.26 MB 0.978 k allocs: 1.27 MB 0.988
eval/Float32/evaluation_turbo_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float64/derivative 4.75 k allocs: 0.0348 GB 4.73 k allocs: 0.0346 GB 1.01
eval/Float64/derivative_turbo 4.8 k allocs: 0.0351 GB 4.77 k allocs: 0.0349 GB 1.01
eval/Float64/evaluation 1.01 k allocs: 2.57 MB 1.01 k allocs: 2.57 MB 1
eval/Float64/evaluation_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
eval/Float64/evaluation_turbo 0.987 k allocs: 2.53 MB 0.99 k allocs: 2.53 MB 0.997
eval/Float64/evaluation_turbo_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
utils/combine_operators/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/convert/break_sharing 2 k allocs: 0.0924 MB 2 k allocs: 0.0924 MB 1
utils/convert/preserve_sharing 2.4 k allocs: 0.161 MB 2.4 k allocs: 0.161 MB 1
utils/copy/break_sharing 2 k allocs: 0.0924 MB 2 k allocs: 0.0924 MB 1
utils/copy/preserve_sharing 2.4 k allocs: 0.161 MB 2.4 k allocs: 0.161 MB 1
utils/count_constant_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_constant_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/count_depth/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/get_set_constants!/break_sharing 0.898 k allocs: 25.2 kB 0.898 k allocs: 25.2 kB 1
utils/get_set_constants!/preserve_sharing 1.7 k allocs: 0.138 MB 1.7 k allocs: 0.138 MB 1
utils/get_set_constants_parametric 1.42 k allocs: 0.0663 MB 1.42 k allocs: 0.0663 MB 1
utils/has_constants/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/has_operators/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/hash/break_sharing 0.104 k allocs: 2.52 kB 0.104 k allocs: 2.52 kB 1
utils/hash/preserve_sharing 0.504 k allocs: 0.0711 MB 0.504 k allocs: 0.0711 MB 1
utils/index_constant_nodes/break_sharing 1.67 k allocs: 0.0501 MB 1.67 k allocs: 0.0501 MB 1
utils/index_constant_nodes/preserve_sharing 2.07 k allocs: 0.119 MB 2.07 k allocs: 0.119 MB 1
utils/is_constant/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/simplify_tree/break_sharing 1.33 k allocs: 0.0436 MB 1.33 k allocs: 0.0436 MB 1
utils/simplify_tree/preserve_sharing 1.58 k allocs: 0.101 MB 1.58 k allocs: 0.101 MB 1
utils/string_tree/break_sharing 11.8 k allocs: 1.04 MB 11.8 k allocs: 1.04 MB 1
utils/string_tree/preserve_sharing 12.2 k allocs: 1.11 MB 12.2 k allocs: 1.11 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@MilesCranmer MilesCranmer mentioned this pull request Jun 14, 2025
Merged
@MilesCranmer MilesCranmer merged commit 3279fbc into master Jun 14, 2025
12 checks passed
@MilesCranmer MilesCranmer deleted the fix-zygote-mutation branch June 14, 2025 20:43
@coveralls
Copy link

coveralls commented Jun 14, 2025

Pull Request Test Coverage Report for Build 15655788566

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix-zygote-mutation at 95.586%
Totals Coverage Status
Change from base Build 15655729819: 95.6%
Covered Lines: 2577
Relevant Lines: 2696
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MilesCranmer @coveralls